Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S2 perf improvements #563

Merged
merged 8 commits into from
Sep 4, 2024
Merged

S2 perf improvements #563

merged 8 commits into from
Sep 4, 2024

Conversation

markus-wa
Copy link
Owner

No description provided.

@markus-wa markus-wa requested a review from akiver September 4, 2024 15:10
@markus-wa markus-wa force-pushed the s2-perf-improvements branch from 0a6464a to 1b1a438 Compare September 4, 2024 15:12
@markus-wa
Copy link
Owner Author

@akiver could you review this and post pre & post change benchmarks for your machine as well? just to make sure this is an improvement on Windows / other devices too

@markus-wa markus-wa mentioned this pull request Sep 4, 2024
Draft
@markus-wa markus-wa force-pushed the s2-perf-improvements branch from e01d077 to b8fd000 Compare September 4, 2024 18:20
@akiver
Copy link
Collaborator

akiver commented Sep 4, 2024

I tested on mac/windows and it's better in all cases 👍

Windows

master:

goos: windows
goarch: amd64
pkg: github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs
cpu: 13th Gen Intel(R) Core(TM) i5-13600KF
BenchmarkDemoInfoCs-20                 4        2976850600 ns/op        7994848194 B/op 11047859 allocs/op
BenchmarkInMemory-20                   5        2413491580 ns/op        7986605526 B/op 10989648 allocs/op
BenchmarkConcurrent-20                 2        6395466800 ns/op        63902382920 B/op        87660255 allocs/op

s2-perf-improvements:

goos: windows
goarch: amd64
pkg: github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs
cpu: 13th Gen Intel(R) Core(TM) i5-13600KF
BenchmarkDemoInfoCs-20                 7        2009648971 ns/op        918736443 B/op  10276525 allocs/op
BenchmarkInMemory-20                   8        1395558238 ns/op        918091017 B/op  10275665 allocs/op
BenchmarkConcurrent-20                 4        2568514200 ns/op        7344828788 B/op 82208329 allocs/op

macOS

master:

goos: darwin
goarch: arm64
pkg: github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs
BenchmarkDemoInfoCs-10             4    3372110792 ns/op    7993860270 B/op 11051004 allocs/op
BenchmarkInMemory-10               4    2766550750 ns/op    7986253350 B/op 10992509 allocs/op
BenchmarkConcurrent-10             1    10110537875 ns/op   63888687904 B/op    87641695 allocs/op

s2-perf-improvements:

goos: darwin
goarch: arm64
pkg: github.com/markus-wa/demoinfocs-golang/v4/pkg/demoinfocs
BenchmarkDemoInfoCs-10             5    2008047142 ns/op    918346136 B/op  10276539 allocs/op
BenchmarkInMemory-10               6    1883063833 ns/op    917931593 B/op  10275604 allocs/op
BenchmarkConcurrent-10             4    3075833958 ns/op    7343135016 B/op 82204428 allocs/op

@markus-wa markus-wa force-pushed the s2-perf-improvements branch from 1bbb578 to e7c8b7f Compare September 4, 2024 22:26
@markus-wa markus-wa merged commit ff602ae into master Sep 4, 2024
8 checks passed
@markus-wa markus-wa deleted the s2-perf-improvements branch September 4, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants